WilliamChen-luckbob commented on a change in pull request #4779:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4779#discussion_r579901998
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -575,23 +596,6 @@ private ProcessInstance
generateNewProcessInstance(ProcessDefinition processDefi
}
}
}
-
Review comment:
@CalvinKirs
Hi! Thanks a lot for your help.
So far I've met a little question about code coverage failed.
I've tested my commitment in my produce environment.
But if I wanted to submit this PR, I have to pass the sonar Analysis too ,
but failed.
According to the details of sonar cloud, I think if I want to cover my
commitment, I have to create a unit test for those I have changed by creating
process definition first, and then run it with my customized start parameter
and then rerun it.
In order to achieve this goal I have to get process definition id and
process instance id, it seems to have no way to get this two parameters. Maybe
it will work if I test my code as the same way as
org.apache.dolphinscheduler.api.service.ExecutorService2Test.java.
So far, I don't have confidence if it would work. I'll try it later after
work.
Could you please give me some instructions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
