CalvinKirs commented on a change in pull request #4779:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4779#discussion_r581983608
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -599,6 +599,26 @@ private ProcessInstance
generateNewProcessInstance(ProcessDefinition processDefi
return processInstance;
}
+ private void setGlobalParamIfCommanded(ProcessDefinition
processDefinition, Map<String, String> cmdParam) {
+ // get start params from command param
Review comment:
Thank you very much for your contribution, but I noticed that this piece
of code is also used elsewhere (generateNewProcessInstance), and it is best to
modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
