dddyszy commented on a change in pull request #4841:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4841#discussion_r582430086
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
##########
@@ -90,7 +90,7 @@ public boolean typeIsSuccess() {
* @return status
*/
public boolean typeIsFailure() {
- return this == FAILURE || this == NEED_FAULT_TOLERANCE || this == KILL;
+ return this == FAILURE || this == NEED_FAULT_TOLERANCE;
}
Review comment:
i checked the same method in release-1.3.5,it just has two,and i also
check the usage of this method,dev branch has one more usage,and i also change
it.please see the pictures
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
