CalvinKirs commented on a change in pull request #4885:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4885#discussion_r584054664
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java
##########
@@ -664,12 +661,7 @@ public static String getAcitveRMName(String rmIds) {
}
} catch (Exception e) {
- for (int i = 1; i < rmIdArr.length; i++) {
- String state = getRMState(String.format(yarnUrl,
rmIdArr[i]));
- if (Constants.HADOOP_RM_STATE_ACTIVE.equals(state)) {
- return rmIdArr[i];
- }
Review comment:
This area may need to be read by others. Although I think your approach
is correct, we still need to consider historical reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
