CalvinKirs commented on a change in pull request #4906:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4906#discussion_r584646799
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
##########
@@ -44,6 +44,7 @@
*/
public class NetUtils {
+ private static final Pattern MASTER_WORKER_STS_PATTERN =
Pattern.compile("(master|worker)-\\d+$");
Review comment:
Whether there are other better methods,?to judge by
MASTER_WORKER_STS_PATTERN, does not seem to be a good method. NetUtils don't
recommend has business mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
