lgcareer commented on pull request #4852: URL: https://github.com/apache/incubator-dolphinscheduler/pull/4852#issuecomment-788540718
> I have a question for the DolphinScheduler PMC, why you are requiring all Apache 2.0 licenses in your dist folder? SkyWalking and DolphinScheduler are in the same foundation, we are using the same License. Basically, you just need to mention Apache SkyWalking is included in your distribution, but I can't find your dist LICENSE change, where is it? > Then about the dependencies of SkyWalking's agent, there are byte-buddy, grpc, protobuf(and several others) included in the SkyWalking binary, so checking through the jar files is not accurate in every case, such as this one. Thanks for tips and help,If the license of new dependencies are standard apache 2.0 license,It's not necceary to add the new license file under the folder dolphinscheduler-dist/release-docs,but it need to be added under dolphinscheduler-dist/release-docs/LICENSE. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
