chengshiwen commented on a change in pull request #4916:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4916#discussion_r588042699
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java
##########
@@ -72,6 +79,9 @@ public void start() {
mutex = new InterProcessMutex(getZkClient(), znodeLock);
mutex.acquire();
+ // Master registry
+ masterRegistry.registry();
+
Review comment:
Indent problem
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java
##########
@@ -94,6 +104,7 @@ public void start() {
@Override
public void close(){
super.close();
+ masterRegistry.unRegistry();
Review comment:
Indent problem
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java
##########
@@ -272,9 +286,8 @@ private boolean checkTaskAfterWorkerStart(TaskInstance
taskInstance) {
if(workerServerStartDate != null){
return
taskInstance.getStartTime().after(workerServerStartDate);
- }else{
- return false;
- }
+ }
+ return false;
Review comment:
Indent problem
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java
##########
@@ -160,6 +171,9 @@ private void removeZKNodePath(String path, ZKNodeType
zkNodeType, boolean failov
* @throws Exception exception
*/
private void failoverServerWhenDown(String serverHost, ZKNodeType
zkNodeType) throws Exception {
+ if (StringUtils.isEmpty(serverHost)) {
Review comment:
Indent problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
