zhuangchong commented on pull request #4987: URL: https://github.com/apache/incubator-dolphinscheduler/pull/4987#issuecomment-791950773
@chengshiwen Are you sure it's related to the -Dlogging.config=classpath:logback-master.xml parameter setting? What I'm saying is very unclear This PR fixes two problems: 1. After receiving the result of processing the specific task, the master will execute the delete task execution script. Since the task execution script is created by the worker, I think it is unreasonable for the master to delete it here. Therefore, this part of code has been deleted, and the plug-in of task nodes will be taken into consideration in the later work. 2. After the master sends the task to receive the processing result of the task, it processes the processInstance several times, and the processDefinition is empty. I have found that this field is not used after the code, so I have deleted the set processDefinition operation after the object conversion —- 这个pr修复的是两个问题，1.master接受到具体任务处理完的结果后，执行删除任务执行脚本。因为任务执行脚本是worker负责创建，此处用master去删除我认为是不合理的，所以删除了这部分代码，待后期做任务节点插件化在考虑进去。2.在master发送任务到接收任务处理结果，对processInstance多次加工，processDefinition为空，我查找了代码后面没有用到这个字段，所以删除了对象转换后的set ProcessDefinition操作 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
