CalvinKirs commented on a change in pull request #4936:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4936#discussion_r589393988
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskKillProcessor.java
##########
@@ -192,12 +196,13 @@ private TaskKillResponseCommand
buildKillTaskResponseCommand(TaskKillRequestComm
}
} catch (Exception e) {
logger.error("kill yarn job error", e);
+ throw new RuntimeException("kill yarn job error");
Review comment:
Throwing an exception does not seem to be a good way to deal with it.
Maybe it would be better if the return parameter of this method is
Pair<Boolean, List<String>>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
