CalvinKirs commented on a change in pull request #5020:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5020#discussion_r592162163
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java
##########
@@ -51,7 +49,13 @@ private PropertyUtils() {
}
static {
- String[] propertyFiles = new String[]{COMMON_PROPERTIES_PATH};
+ loadPropertyFile(COMMON_PROPERTIES_PATH);
+ }
+
+ /**
+ * init properties
+ */
+ public static void loadPropertyFile(String... propertyFiles) {
for (String fileName : propertyFiles) {
InputStream fis = null;
try {
Review comment:
Your own rightness should not be tied to the specific business.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
