chengshiwen commented on pull request #5036: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5036#issuecomment-797200981
> > It's a good job! At the same time, I'm also thinking about some work to make DolphinScheduler better with the `HOME` environment variables. Please refer to #5035. If you are interested, you can work together to optimize this problem with me. > > For python, `python` (alias `python2`) in `/usr/bin` is usually built into the operating system. So `PYTHON_HOME` is only set for `python3`. So > > > > * If we just use the default built-in `python`, `PYTHON_HOME` is not needed at all. Does it mean it is better to comment `PYTHON_HOME` by default? > > * If `python2` and `python3` are in the `/usr/bin` directory at the same time, how to solve the problem that people want to use `python3` under `PYTHON_HOME=/usr/bin`? In our official docker image, `python2` and `python3` are in the `/usr/bin` directory. > > * If the second problem cannot be solved, is it better to rename `PYTHON_HOME` to `PYTHON_PATH` only? > > > > Dealing with python well may require some thinking and design. Through this pr, we can try to make python better!🚀🚀🚀 > > @chengshiwen I think we should add the configuration of environment variables to the node Settings or workflow global Settings, which has solved the problem of multiple environments. This is what our company has done at present, which has solved the problem of multiple Hadoop environments Maybe this problem needs another pr to finish. Could you finish the request changes and resolve the conflicts? After finishing the work, we will merge this pr, thx a lot! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
