CalvinKirs commented on a change in pull request #5060:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5060#discussion_r594361290
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml
##########
@@ -139,4 +139,12 @@
set version = #{version}
where id = #{processDefinitionId}
</update>
+
+ <select id="queryDefinitionByIdAndVersion"
resultType="org.apache.dolphinscheduler.dao.entity.ProcessDefinition">
+ select
+ <include refid="baseSql"/>
Review comment:
You only need to know if there is data, so it is recommended to return
the ID. At the same time, select the best to add limit conditions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
