wen-hemin commented on a change in pull request #5019:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5019#discussion_r594824307
##########
File path: docker/kubernetes/dolphinscheduler/values.yaml
##########
@@ -76,12 +76,12 @@ common:
- "export HADOOP_CONF_DIR=/opt/soft/hadoop/etc/hadoop"
- "export SPARK_HOME1=/opt/soft/spark1"
- "export SPARK_HOME2=/opt/soft/spark2"
- #- "export PYTHON_HOME=/opt/soft/python"
+ - "export PYTHON_HOME=/usr"
- "export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk"
- "export HIVE_HOME=/opt/soft/hive"
- "export FLINK_HOME=/opt/soft/flink"
- - "export DATAX_HOME=/opt/soft/datax/bin/datax.py"
- - "export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$PATH"
+ - "export DATAX_HOME=/opt/soft/datax"
+ - "export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$DATAX_HOME/bin:$PATH"
Review comment:
There is no need to add to path.
##########
File path: docker/build/conf/dolphinscheduler/env/dolphinscheduler_env.sh.tpl
##########
@@ -25,4 +25,4 @@ export HIVE_HOME=$HIVE_HOME
export FLINK_HOME=$FLINK_HOME
export DATAX_HOME=$DATAX_HOME
-export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$PATH:$FLINK_HOME/bin:$DATAX_HOME:$PATH
+export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$DATAX_HOME/bin:$PATH
Review comment:
There is no need to add to path.
##########
File path: docker/docker-swarm/docker-stack.yml
##########
@@ -171,11 +171,11 @@ services:
HADOOP_CONF_DIR: "/opt/soft/hadoop/etc/hadoop"
SPARK_HOME1: "/opt/soft/spark1"
SPARK_HOME2: "/opt/soft/spark2"
- #PYTHON_HOME: "/opt/soft/python"
+ PYTHON_HOME: "/usr"
Review comment:
This is not within the scope of this change and no modification is
recommended.
##########
File path: docker/docker-swarm/docker-compose.yml
##########
@@ -177,11 +177,11 @@ services:
HADOOP_CONF_DIR: "/opt/soft/hadoop/etc/hadoop"
SPARK_HOME1: "/opt/soft/spark1"
SPARK_HOME2: "/opt/soft/spark2"
- #PYTHON_HOME: "/opt/soft/python"
+ PYTHON_HOME: "/usr"
Review comment:
This is not within the scope of this change and no modification is
recommended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
