chengshiwen commented on a change in pull request #5066: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5066#discussion_r595074422
########## File path: sql/upgrade/1.3.6_schema/postgresql/dolphinscheduler_ddl.sql ########## @@ -0,0 +1,18 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ +-- Add foreign key constraints for t_ds_task_instance -- +alter table t_ds_task_instance add FOREIGN key(process_instance_id) REFERENCES t_ds_process_instance(id) ON DELETE CASCADE; Review comment: It would be better to keep the key world's case consistent ########## File path: sql/dolphinscheduler_postgre.sql ########## @@ -556,7 +556,7 @@ CREATE TABLE t_ds_task_instance ( name varchar(255) DEFAULT NULL , task_type varchar(64) DEFAULT NULL , process_definition_id int DEFAULT NULL , - process_instance_id int DEFAULT NULL , + process_instance_id int REFERENCES t_ds_process_instance (id) DEFAULT NULL , Review comment: It would be better to reduce an extra space ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
