CalvinKirs commented on a change in pull request #5070:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5070#discussion_r596492367
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java
##########
@@ -293,7 +294,7 @@ private boolean checkQueueNameExist(String queueName) {
* @return true if need to update user
*/
private boolean checkIfQueueIsInUsing (String oldQueue, String newQueue) {
- return !oldQueue.equals(newQueue) &&
CollectionUtils.isNotEmpty(userMapper.queryUserListByQueue(oldQueue));
+ return !oldQueue.equals(newQueue) &&
BooleanUtils.isNotTrue(userMapper.existUser(oldQueue));
}
}
Review comment:
There is a problem here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
