chengshiwen commented on a change in pull request #5104:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5104#discussion_r597552978
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/utils/MailUtils.java
##########
@@ -85,15 +101,6 @@
*/
public static Map<String,Object> sendMails(Collection<String> receivers,
Collection<String> receiversCc, String title, String content, String showType) {
Map<String,Object> retMap = new HashMap<>();
-
- // if mail is default config, no need to process
- if (StringUtils.isEmpty(MAIL_SERVER_HOST) ||
"xxx.xxx.com".equals(MAIL_SERVER_HOST)) {
- retMap.put(Constants.MAIL_ENABLED, false);
- retMap.put(Constants.STATUS, true);
- return retMap;
- }
-
- retMap.put(Constants.MAIL_ENABLED, true);
Review comment:
These lines were added by me in last `1.3.5` version, in order to solve
the problem of `sending mail failed`, now they are not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
