This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new f6d62a4  [Improvement-5144][UI] error v-show directives cannot be put 
on template tags (#5145)
f6d62a4 is described below

commit f6d62a4924417fbcdea35ba2896a652eb9bc735c
Author: zhuangchong <[email protected]>
AuthorDate: Fri Mar 26 16:42:13 2021 +0800

    [Improvement-5144][UI] error v-show directives cannot be put on template 
tags (#5145)
    
    * fix error v-show directives cannot be put on template tags.
    
    * rerun e2e.
---
 .../js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue | 4 ++--
 .../src/js/conf/home/pages/resource/pages/file/pages/edit/index.vue  | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
 
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
index 252fedc..c938948 100644
--- 
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
+++ 
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
@@ -29,10 +29,10 @@
             </a>
           </div>
         </div>
-        <template v-show="!isNodata">
+        <template v-if="!isNodata">
           <div class="gantt"></div>
         </template>
-        <template v-if="isNodata">
+        <template v-else>
           <m-no-data></m-no-data>
         </template>
         <m-spin :is-spin="isLoading">
diff --git 
a/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/edit/index.vue
 
b/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/edit/index.vue
index e4c7586..7e8c5ed 100644
--- 
a/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/edit/index.vue
+++ 
b/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/edit/index.vue
@@ -21,7 +21,7 @@
         <h2>
           <span>{{name}}</span>
         </h2>
-        <template v-show="isViewType">
+        <template v-if="isViewType">
           <template v-if="!msg">
             <div class="code-mirror-model">
               <textarea id="code-edit-mirror" 
name="code-edit-mirror"></textarea>
@@ -32,9 +32,8 @@
             </div>
           </template>
           <m-no-data :msg="msg" v-if="msg"></m-no-data>
-
         </template>
-        <template v-if="!isViewType">
+        <template v-else>
           <m-no-type></m-no-type>
         </template>
       </div>

Reply via email to