lenboo commented on a change in pull request #5193:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5193#discussion_r605349483
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2356,26 +2360,40 @@ public void createTaskAndRelation(User operator,
}
updateTaskDefinition(operator, projectCode, taskNode,
taskDefinition);
}
- taskNameAndCode.put(taskNode.getName(), taskDefinition);
+ taskDefinitionMap.put(taskNode.getName(), taskDefinition);
+ }
+ return taskDefinitionMap;
+ }
+
+ /**
+ * handle task relations
+ */
+ public int handleTaskRelation(User operator,
+ Long projectCode,
+ ProcessDefinition processDefinition,
+ List<TaskNode> taskNodes,
+ Map<String, TaskDefinition>
taskDefinitionMap) {
+ if (null == processDefinition || null == taskNodes || null ==
taskDefinitionMap) {
+ return Constants.EXIT_CODE_FAILURE;
Review comment:
the exit code constant is used on task execution result.
you can replace it with another constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
