ruanwenjun commented on a change in pull request #5185:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5185#discussion_r606104535
##########
File path: dolphinscheduler-common/test/testFile.txt
##########
@@ -0,0 +1 @@
+正正正faffdasfasdfas
Review comment:
ignore this file
##########
File path: dolphinscheduler-common/sql/soft_version
##########
@@ -0,0 +1 @@
+32432423
Review comment:
ignore this file
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -149,8 +150,7 @@
from t_ds_process_instance t
join t_ds_process_definition d on d.id=t.process_definition_id
join t_ds_project p on p.id=d.project_id
- where 1 = 1
- and t.is_sub_process = 0
+ where and t.is_sub_process = 0
Review comment:
Should remove `and`
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UserMapper.xml
##########
@@ -19,7 +19,7 @@
<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN"
"http://mybatis.org/dtd/mybatis-3-mapper.dtd"; >
<mapper namespace="org.apache.dolphinscheduler.dao.mapper.UserMapper">
<sql id="baseSql">
- id, user_name, user_password, user_type, email, phone, tenant_id,
create_time, update_time, queue, state
+ id, user_name, user_password, user_type, email, phone, tenant_id,
create_time, update_time, queue, `state`
Review comment:
For the Sql style consistency, maybe it better not to make this
modification ~~
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##########
@@ -42,17 +42,17 @@
import org.apache.dolphinscheduler.service.alert.AlertClientService;
import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.InputStreamReader;
+import java.nio.charset.Charset;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.SQLException;
import java.sql.Statement;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Optional;
+import java.util.*;
Review comment:
The use of import * is considered a bad practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
