sincere2018 opened a new issue #5218:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5218
Describe the question：
When I set the priority of the task instance, it does not take effect. So
I found the source code.Line 221 of MasterBaseTaskExecThread in the server
module，The code is as follows:
/**
* taskPriority
*/
TaskPriority taskPriority =
buildTaskPriority(processInstance.getProcessInstancePriority().getCode(),
processInstance.getId(),
taskInstance.getProcessInstancePriority().getCode(),
taskInstance.getId(),
org.apache.dolphinscheduler.common.Constants.DEFAULT_WORKER_GROUP);
taskUpdateQueue.put(taskPriority);
logger.info(String.format("master submit success, task : %s",
taskInstance.getName()) );
return true;
The third parameter in buildTaskPriorityInfo is the task instance
priority，However, the process instance priority is still used in the code. So
I think it should be rewritten this way.
/**
* taskPriority
*/
TaskPriority taskPriority =
buildTaskPriority(processInstance.getProcessInstancePriority().getCode(),
processInstance.getId(),
taskInstance.getTaskInstancePriority().getCode(), // modify
here
taskInstance.getId(),
org.apache.dolphinscheduler.common.Constants.DEFAULT_WORKER_GROUP);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
