didiaode18 commented on a change in pull request #5200:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/5200#discussion_r611002899



##########
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java
##########
@@ -612,7 +607,9 @@ public static String getAppAddress(String appAddress, 
String rmHa) {
             return null;
         }
 
-        String end = Constants.COLON + split2[1];
+        String activeResourceManagerPort = 
String.valueOf(PropertyUtils.getInt(Constants.HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT,
 8088));
+        String rest = split2[1].substring(activeResourceManagerPort.length());
+        String end = Constants.COLON + activeResourceManagerPort + rest;

Review comment:
       1 # if resourcemanager HA enable or not use resourcemanager, please keep 
the default value; If resourcemanager is single, you only need to replace ds1 
to actual resourcemanager hostname.
   yarn.application.status.address=http://ds1:8088/ws/v1/cluster/apps/%s
   # if custom you  resourcemanager port ,you need to replace 8088 else default 
value.
   resource.manager.httpaddress.port=8088
   2 I think this port should be set separately




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to