ruanwenjun commented on a change in pull request #5243:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5243#discussion_r612894553
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/datax/DataxTask.java
##########
@@ -462,7 +462,10 @@ public String loadJvmEnv(DataxParameters dataXParameters) {
try {
SQLStatementParser parser =
DataxUtils.getSqlStatementParser(dbType, sql);
- notNull(parser, String.format("database driver [%s] is not
support", dbType.toString()));
+ if (parser == null) {
+ logger.warn("database driver [{}] is not support grammatical
analysis sql", dbType);
+ return new String[0];
Review comment:
I think there is no problem returning null, but the code smell check
suggest we should use empty array to replace null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
