qingzhongli commented on pull request #5390: URL: https://github.com/apache/dolphinscheduler/pull/5390#issuecomment-828397975
> > > > Are the following changes necessary ? > > > > `dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskType.java dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/TaskParametersUtils.java` > > > > > > > > > I think this is necessary. The modification is for task plug-in extension > > > > > > Is it difficult to extend task plug-in before the modification? can you explain it in detail? > > i think it's better to use string to express the task-type, instead of the enum. > if you want a new task type, you just write the new type in the configuration, without modifying the code. Got it. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
