[GitHub] [dolphinscheduler] chengshiwen commented on a change in pull request #5594: [Fix-5468][Common] Fix obtaining IP is incorrect

Mon, 07 Jun 2021 01:08:23 -0700 


chengshiwen commented on a change in pull request #5594:
URL: https://github.com/apache/dolphinscheduler/pull/5594#discussion_r646362020



##########
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
##########
@@ -130,7 +128,7 @@ private static synchronized InetAddress getLocalAddress0() {
                     Optional<InetAddress> addressOp = 
toValidAddress(addresses.nextElement());
                     if (addressOp.isPresent()) {
                         try {
-                            if (addressOp.get().isReachable(100)) {
+                            if (addressOp.get().isReachable(300)) {

Review comment:
       There is a scenario: the 2nd ip is used, not the 1st ip
   
![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png)
   
![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to