wen-hemin commented on a change in pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#discussion_r648076227
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2240,6 +2303,7 @@ public int saveProcessDefinition(User operator, Project
project, String name, St
/**
* save processDefinition
*/
+ @Deprecated
Review comment:
Is this method unnecessary?
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -232,23 +239,26 @@ public Result verifyProcessDefinitionName(@ApiIgnore
@RequestAttribute(value = C
public Result updateProcessDefinition(@ApiIgnore @RequestAttribute(value =
Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectName",
value = "PROJECT_NAME", required = true) @PathVariable String projectName,
@RequestParam(value = "name",
required = true) String name,
- @RequestParam(value = "id", required
= true) int id,
- @RequestParam(value =
"processDefinitionJson", required = true) String processDefinitionJson,
- @RequestParam(value = "locations",
required = false) String locations,
- @RequestParam(value = "connects",
required = false) String connects,
+ @RequestParam(value = "code",
required = true) long code,
@RequestParam(value = "description",
required = false) String description,
Review comment:
Field need to be preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
