[GitHub] [dolphinscheduler] kyoty commented on a change in pull request #5611: [Fix-5540][JSON Split] Fix some new tables and fields are missing in the sql upgrade script

Thu, 10 Jun 2021 05:00:26 -0700 


kyoty commented on a change in pull request #5611:
URL: https://github.com/apache/dolphinscheduler/pull/5611#discussion_r649113722



##########
File path: sql/dolphinscheduler_postgre.sql
##########
@@ -303,7 +303,7 @@ CREATE TABLE t_ds_process_definition (
   tenant_id int DEFAULT '-1' ,
   create_time timestamp DEFAULT NULL ,
   update_time timestamp DEFAULT NULL ,
-  PRIMARY KEY (id) ,
+  PRIMARY KEY (id, code) ,

Review comment:
       Thanks for your review.
   I made this change by folllowing the same table schema in 
mysql:https://github.com/apache/dolphinscheduler/blob/5d3b75a0a32da02ad562386a8253727ab0dc6b75/sql/dolphinscheduler_mysql.sql#L411
  I've also update the sql upgrade script.
   I'm not sure what's the best way to do? 😭 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to