wen-hemin commented on a change in pull request #5630:
URL: https://github.com/apache/dolphinscheduler/pull/5630#discussion_r650724704
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.xml
##########
@@ -29,7 +29,7 @@
select
<include refid="baseSql"/>
from t_ds_project
- where code = #{code}
+ where code = #{projectCode}
Review comment:
The change of variable name is not seen in mapper class,
Are you sure it doesn't need to be modified.
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java
##########
@@ -268,28 +264,28 @@ public boolean hasProjectAndPerm(User loginUser, Project
project, Map<String, Ob
* updateProcessInstance project
*
* @param loginUser login user
- * @param projectId project id
+ * @param projectCode project code
* @param projectName project name
* @param desc description
* @param userName project owner
* @return update result code
*/
@Override
- public Map<String, Object> update(User loginUser, Integer projectId,
String projectName, String desc, String userName) {
+ public Map<String, Object> update(User loginUser, Long projectCode, String
projectName, String desc, String userName) {
Map<String, Object> result = new HashMap<>();
Map<String, Object> descCheck = checkDesc(desc);
if (descCheck.get(Constants.STATUS) != Status.SUCCESS) {
return descCheck;
}
- Project project = projectMapper.selectById(projectId);
+ Project project = projectMapper.queryByCode(projectCode);
boolean hasProjectAndPerm = hasProjectAndPerm(loginUser, project,
result);
if (!hasProjectAndPerm) {
return result;
}
Project tempProject = projectMapper.queryByName(projectName);
- if (tempProject != null && tempProject.getId() != projectId) {
+ if (tempProject != null && tempProject.getCode().equals(projectCode)) {
Review comment:
not equals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
