CalvinKirs commented on pull request #5659:
URL: https://github.com/apache/dolphinscheduler/pull/5659#issuecomment-863438763


   > @CalvinKirs Thanks for your reply.
   > I don't know much about the background of this refractor, but for now, it 
seems ZK-related information really shouldn't be treated as properties of 
abstract methods.
   > How do you feel about adding a new class of monitoring specifically for 
ZK, such as adding a `ZKRegistryMonitor class` in addition to the 
RegistryMonitor for the ZooKeePerRegistry?
   > I can't think of a better way...
   
   I'm considering whether I need to remove the monitoring of the registry, 
which in my opinion is not something that DS needs to manage. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to