This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new e2eed1f  [Improvement] Fix a potential problem when editing an 
existing mysql data source
e2eed1f is described below

commit e2eed1f24f05a2d6fdfda36fad2afe31324d5a1f
Author: kyoty <[email protected]>
AuthorDate: Mon Jun 21 18:52:25 2021 +0800

    [Improvement] Fix a potential problem when editing an existing mysql data 
source
---
 .../apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
index 382339a..d895576 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
@@ -158,7 +158,7 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
 
         Result<Object> isConnection = checkConnection(dataSource.getType(), 
connectionParam);
         if (Status.SUCCESS.getCode() != isConnection.getCode()) {
-            return result;
+            return isConnection;
         }
 
         Date now = new Date();

Reply via email to