chengshiwen commented on a change in pull request #5684:
URL: https://github.com/apache/dolphinscheduler/pull/5684#discussion_r656781153



##########
File path: 
dolphinscheduler-ui/src/js/conf/home/pages/user/pages/account/_source/info.vue
##########
@@ -110,6 +111,7 @@
           phone: param.phone
         })
         this.createUserDialog = false
+        this.getUserInfo()

Review comment:
       Good job!
   
   This pr has reached the goal.
   In the user experience, it's better to replace the following lines
   ```javascript
   this.createUserDialog = false
   this.getUserInfo()
   ```
   with
   ```javascript
   this.getUserInfo().finally(() => {
     this.createUserDialog = false
   })
   ```
   Of course it doesnโ€™t matter if you donโ€™t modify it ๐Ÿ˜ƒ๐Ÿ˜ƒ๐Ÿ˜ƒ




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to