kyoty commented on a change in pull request #5676:
URL: https://github.com/apache/dolphinscheduler/pull/5676#discussion_r659984693
##########
File path:
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java
##########
@@ -83,6 +83,7 @@ private DolphinPluginDiscovery() {
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
+ .map(plugin -> plugin.replace(File.separatorChar, '.'))
Review comment:
@ruanwenjun Thanks for your patient view.
```java
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
.collect(Collectors.toSet());
```
as the listClasses determines what kind of str to return. I try to add a new
method in replace javaName in listClasses, now it works fine in windows, I'll
test it in unix system tomorrow, do you have any better idea?
##########
File path:
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java
##########
@@ -83,6 +83,7 @@ private DolphinPluginDiscovery() {
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
+ .map(plugin -> plugin.replace(File.separatorChar, '.'))
Review comment:
@ruanwenjun Thanks for your patient view.
```java
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
.collect(Collectors.toSet());
```
as the `listClasses` determines what kind of str to return. I try to add a
new method in replace `javaName` in listClasses, now it works fine in windows,
I'll test it in unix system tomorrow, do you have any better idea?
##########
File path:
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java
##########
@@ -83,6 +83,7 @@ private DolphinPluginDiscovery() {
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
+ .map(plugin -> plugin.replace(File.separatorChar, '.'))
Review comment:
@ruanwenjun Thanks for your patient view.
```java
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
.collect(Collectors.toSet());
```
as the `listClasses` determines what kind of str to return. I try to add a
new method to replace `javaName` in listClasses, now it works fine in windows,
I'll test it in unix system tomorrow, do you have any better idea?
##########
File path:
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java
##########
@@ -83,6 +83,7 @@ private DolphinPluginDiscovery() {
return listClasses(file.toPath()).stream()
.filter(name -> classInterfaces(name,
classLoader).contains(DolphinSchedulerPlugin.class.getName()))
+ .map(plugin -> plugin.replace(File.separatorChar, '.'))
Review comment:
@ruanwenjun I've test it under ubuntu, it works as expected, thanks for
your great help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
