JinyLeeChina commented on a change in pull request #5695:
URL: https://github.com/apache/dolphinscheduler/pull/5695#discussion_r660558159



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ParamUtils.java
##########
@@ -87,49 +91,67 @@
                  *  and there are no variables in them.
                  */
                 String val = property.getValue();
-                val  = ParameterUtils.convertParameterPlaceholders(val, 
timeParams);
+                val = ParameterUtils.convertParameterPlaceholders(val, 
timeParams);
                 property.setValue(val);
             }
         }
 
+        // set the schedule time

Review comment:
       Thanks for your contribution. I don't think the spark parameter can be 
modified here, which will affect other components, please check




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to