kyoty opened a new pull request #5727:
URL: https://github.com/apache/dolphinscheduler/pull/5727


   ## Purpose of the pull request
   1. fix the issue: #5726
   2. enhance the logic in #5696 , **it's my fault that I failed to submit the 
latest code about 'createWarning.vue' due to the network error,  and I'm very 
sorry.**
   
   ## Brief change log
   + When editing an existing data source, the data source type should be 
changed.
   + When editing an existing data source, the name of the existing data source 
can be changed as expected.
   + When trying to create an token, if the expiration time is empty,It should 
be prevented at the front end
   + Non-Admin user profile page could display tenant information  as expected.
   + When trying to create an alarm instance, if the alarm plugin is empty, It 
should be prevented at the front end (#5696  case)
   
   ## Verify this pull request
   
   Manually verified the change by testing locally.
   
   1.  munual test works well like this:    
   
   
![image](https://user-images.githubusercontent.com/52202080/123959152-6c6e4600-d9e0-11eb-94e8-38940983bc54.png)
   
     
   
   2.  update the name of existing dataouse can work as expected:  
   
![image](https://user-images.githubusercontent.com/52202080/123959120-64160b00-d9e0-11eb-810f-6565913c7156.png)
     
   
   3. When trying to create an token, if the expiration time is empty,It should 
be prevented at the front end    
   
![image](https://user-images.githubusercontent.com/52202080/123959227-80b24300-d9e0-11eb-80f6-b7f1e3fa15fe.png)
  
     
   
   4. Non-Admin user profile page does not display tenant information    
   
![image](https://user-images.githubusercontent.com/52202080/123959346-a3dcf280-d9e0-11eb-8093-939db5bdefc5.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to