kyoty commented on a change in pull request #5715:
URL: https://github.com/apache/dolphinscheduler/pull/5715#discussion_r661458289
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java
##########
@@ -109,12 +110,19 @@
@Override
public Map<String, Object> update(User loginUser, int pluginInstanceId,
String instanceName, String pluginInstanceParams) {
- AlertPluginInstance alertPluginInstance = new AlertPluginInstance();
+ Map<String, Object> result = new HashMap<>();
+
+ AlertPluginInstance alertPluginInstance =
alertPluginInstanceMapper.queryById(pluginInstanceId);
+
+ if (alertPluginInstance == null) {
+ putMsg(result, Status.QUERY_PLUGINS_RESULT_IS_NULL,
pluginInstanceId);
Review comment:
Thanks @ruanwenjun .
My solution is too complicated, I have update what you said, please help to
review again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
