ruanwenjun commented on a change in pull request #5766:
URL: https://github.com/apache/dolphinscheduler/pull/5766#discussion_r665889055



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZookeeperMonitor.java
##########
@@ -91,7 +89,7 @@
                 float avgLatency = state.getAvgLatency();
                 float maxLatency = state.getMaxLatency();
                 int nodeCount = state.getNodeCount();
-                int status = ok ? 1 : 0;
+                int status = state.isFlag() ? -1: (ok ? 1 : 0);

Review comment:
       I think return true or false to front-end may be better than returning 
0,1. 
   And if return -1, what will the front-end show in ui?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to