ruanwenjun commented on a change in pull request #5809:
URL: https://github.com/apache/dolphinscheduler/pull/5809#discussion_r669533947
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/datax/DataxTask.java
##########
@@ -554,7 +554,7 @@ public String loadJvmEnv(DataxParameters dataXParameters) {
sql = sql.replace(";", "");
try (
- Connection connection =
DatasourceUtil.getConnection(DbType.valueOf(dataXParameters.getDtType()),
baseDataSource);
+ Connection connection =
DatasourceUtil.getConnection(DbType.valueOf(dataXParameters.getDsType()),
baseDataSource);
Review comment:
Can we modify the method
```java
public String[] tryExecuteSqlResolveColumnNames(BaseConnectionParam
baseDataSource, String sql)
```
to
```java
public String[] tryExecuteSqlResolveColumnNames(DbType dbType,
BaseConnectionParam baseDataSource, String sql)
```
Using `dataXParameters.getDsType()` here seems also confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
