wen-hemin commented on a change in pull request #5828:
URL: https://github.com/apache/dolphinscheduler/pull/5828#discussion_r671624206
##########
File path:
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskDefinitionServiceImplTest.java
##########
@@ -201,6 +179,7 @@ public void deleteTaskDefinitionByCode() {
}
+ /*
Review comment:
If it is unuse, it can be deleted directly.
##########
File path:
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskDefinitionServiceImplTest.java
##########
@@ -50,48 +51,29 @@
@RunWith(MockitoJUnitRunner.class)
public class TaskDefinitionServiceImplTest {
- String taskDefinitionJson = "{\n"
Review comment:
This variable is referenced by many test cases. Does the modification
affect other test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
