ruanwenjun commented on a change in pull request #5832:
URL: https://github.com/apache/dolphinscheduler/pull/5832#discussion_r671643778
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -720,23 +723,50 @@ public ProcessMeta
exportProcessMetaData(ProcessDefinition processDefinition) {
}
/**
- * correct task param which has datasource or dependent
+ * correct task param which has datasource or dependent for export
Review comment:
This method seems to inject some parameters into the TaskNode, I think
the comment may be not clear enough.
And if other parameters will be injected in the future, it is better to
split this method into two separate method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
