Technoboy- commented on a change in pull request #5890:
URL: https://github.com/apache/dolphinscheduler/pull/5890#discussion_r677443023
##########
File path:
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/os/OSUtilsTest.java
##########
@@ -37,39 +33,32 @@
@Test
public void memoryUsage() {
- logger.info("memoryUsage : {}", OSUtils.memoryUsage());//
0.3361799418926239
+ double memoryUsage = OSUtils.memoryUsage();
+ logger.info("memoryUsage : {}", memoryUsage);
+ Assert.assertTrue(memoryUsage >= 0.0);
}
@Test
- public void availablePhysicalMemorySize() {
- logger.info("availablePhysicalMemorySize : {}",
OSUtils.availablePhysicalMemorySize());
- logger.info("availablePhysicalMemorySize : {}",
OSUtils.totalMemorySize() / 10);
+ public void physicalMemorySize() {
+ double availablePhysicalMemorySize =
OSUtils.availablePhysicalMemorySize();
+ double totalPhysicalMemorySize = OSUtils.totalPhysicalMemorySize();
+ logger.info("availablePhysicalMemorySize : {}",
availablePhysicalMemorySize);
+ logger.info("totalPhysicalMemorySize : {}", totalPhysicalMemorySize);
+ Assert.assertTrue(availablePhysicalMemorySize >= 0.0);
+ Assert.assertTrue(totalPhysicalMemorySize >= 0.0);
}
-
@Test
public void loadAverage() {
Review comment:
Test method should named testXXX().
##########
File path:
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/os/OSUtilsTest.java
##########
@@ -37,39 +33,32 @@
@Test
public void memoryUsage() {
Review comment:
Also here
##########
File path:
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/os/OSUtilsTest.java
##########
@@ -37,39 +33,32 @@
@Test
public void memoryUsage() {
- logger.info("memoryUsage : {}", OSUtils.memoryUsage());//
0.3361799418926239
+ double memoryUsage = OSUtils.memoryUsage();
+ logger.info("memoryUsage : {}", memoryUsage);
+ Assert.assertTrue(memoryUsage >= 0.0);
}
@Test
- public void availablePhysicalMemorySize() {
- logger.info("availablePhysicalMemorySize : {}",
OSUtils.availablePhysicalMemorySize());
- logger.info("availablePhysicalMemorySize : {}",
OSUtils.totalMemorySize() / 10);
+ public void physicalMemorySize() {
Review comment:
Could you change the method to testPhysicalMemorySize()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
