CalvinKirs commented on a change in pull request #5931:
URL: https://github.com/apache/dolphinscheduler/pull/5931#discussion_r680517564
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -1110,9 +1111,9 @@ private void importSubProcess(User loginUser, Project
targetProject, ArrayNode j
String subProcessJson =
JSONUtils.toJsonString(processService.genProcessData(subProcess));
//check current project has sub process
- ProcessDefinition currentProjectSubProcess =
processDefinitionMapper.queryByDefineName(targetProject.getCode(),
subProcess.getName());
+ Boolean ifExist =
processDefinitionMapper.existDefByProjectCodeAndDefineName(targetProject.getCode(),
subProcess.getName());
Review comment:
It is best to follow the rules of variable naming, in addition, it is
better to use boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
