zhuangchong commented on pull request #5895:
URL: https://github.com/apache/dolphinscheduler/pull/5895#issuecomment-891479634


   > Just my personal opinion: servece should only contain specific data, 
Result is generally the encapsulated carrier of external interaction data, 
should not be reflected in the service. Related errors can be directly thrown 
exceptions, API unified exception capture interception. This is a historical 
legacy, but it would be better if it could be solved at once.
   
   @CalvinKirs @soreak 
   
   I also agree with this point, this change involves a lot of code, it is 
recommended to start a new PR for optimization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to