allen1128 commented on a change in pull request #5931:
URL: https://github.com/apache/dolphinscheduler/pull/5931#discussion_r684637022



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
##########
@@ -139,7 +140,7 @@
         }
 
         //check name can use or not
-        if (!dataSource.getName().trim().equals(dataSource.getName()) && 
checkName(dataSource.getName())) {
+        if (!dataSource.getName().trim().equals(dataSourceParam.getName()) && 
checkDatasourceNameExist(dataSourceParam.getName())) {

Review comment:
       I found this possible bug while adding the unit test and fixed it. 
Please let me know if it is not a bug.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to