JinyLeeChina commented on a change in pull request #5958:
URL: https://github.com/apache/dolphinscheduler/pull/5958#discussion_r684727109
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -567,41 +567,41 @@ public Result deleteProcessDefinitionById(@ApiIgnore
@RequestAttribute(value = C
*
* @param loginUser login user
* @param projectCode project code
- * @param processDefinitionIds process definition id list
+ * @param processDefinitionCodes process definition code list
* @return delete result code
*/
@ApiOperation(value = "batchDeleteByCodes", notes =
"BATCH_DELETE_PROCESS_DEFINITION_BY_IDS_NOTES")
@ApiImplicitParams({
- @ApiImplicitParam(name = "processDefinitionIds", value =
"PROCESS_DEFINITION_IDS", type = "String")
+ @ApiImplicitParam(name = "processDefinitionCodes", value =
"PROCESS_DEFINITION_CODES", type = "String")
})
@GetMapping(value = "/batch-delete")
@ResponseStatus(HttpStatus.OK)
@ApiException(BATCH_DELETE_PROCESS_DEFINE_BY_IDS_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
- public Result batchDeleteProcessDefinitionByIds(@ApiIgnore
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
- @ApiParam(name =
"projectCode", value = "PROJECT_CODE", required = true) @PathVariable long
projectCode,
-
@RequestParam("processDefinitionIds") String processDefinitionIds
+ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
+ @ApiParam(name =
"projectCode", value = "PROJECT_CODE", required = true) @PathVariable long
projectCode,
+
@RequestParam("processDefinitionCodes") String processDefinitionCodes
) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedIdList = new ArrayList<>();
- if (StringUtils.isNotEmpty(processDefinitionIds)) {
- String[] processDefinitionIdArray =
processDefinitionIds.split(",");
- for (String strProcessDefinitionId : processDefinitionIdArray) {
- int processDefinitionId =
Integer.parseInt(strProcessDefinitionId);
+ List<String> deleteFailedCodeList = new ArrayList<>();
+ if (StringUtils.isNotEmpty(processDefinitionCodes)) {
+ String[] processDefinitionCodeArray =
processDefinitionCodes.split(",");
+ for (String strProcessDefinitionCode : processDefinitionCodeArray)
{
+ long processDefinitionCode =
Long.parseLong(strProcessDefinitionCode);
try {
- Map<String, Object> deleteResult =
processDefinitionService.deleteProcessDefinitionById(loginUser, projectCode,
processDefinitionId);
+ Map<String, Object> deleteResult =
processDefinitionService.deleteProcessDefinitionByCode(loginUser, projectCode,
processDefinitionCode);
Review comment:
Please modify to batch operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
