lyxell commented on pull request #6003:
URL: https://github.com/apache/dolphinscheduler/pull/6003#issuecomment-901884679


   > LGTM
   
   Great!
   
   > And I have a question, when should we use `Collections.emptySet` in 
program, becase this method return an immutable set, If the upper layer want to 
add elements, they need to create a new HashSet.
   
   I think `Collections.emptySet` is a good default. If the user needs a 
modifiable set they can always make a copy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to