reele opened a new pull request #6063:
URL: https://github.com/apache/dolphinscheduler/pull/6063


   ## Purpose of the pull request
   
   * When sub-process task submitted with a finished state, the 
`SubProcessTaskExecThread.waitTaskQuit()` will [return 
directly](https://github.com/apache/dolphinscheduler/blob/e0eea995200f673d6406ec62c464c77f1d5b6171/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/SubProcessTaskExecThread.java#L128),
 and [set task state with sub-process's 
state](https://github.com/reele/dolphinscheduler/blob/3215cfb9f7c62bef7fa197b37ffc38cedd2c7ef5/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/SubProcessTaskExecThread.java#L66)
 (even if the sub-process is running, such as `READY_PAUSE`/`READY_STOP` or 
others), so the sub-process-task will ended with an unfinished state 
(`READY_PAUSE` or `READY_STOP`),
   so the parent thread `MasterExecThread` will fall into an endless-loop.
   
   
   ## Brief change log
   
   `SubProcessTaskExecThread.waitTaskQuit()` should check 
`subProcessInstance`'s state first:
   * If `subProcessInstance` is not null and its state is unfinished, it still 
enters the waiting loop.
   
   ## Issue
   #6062


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to