reele commented on a change in pull request #6063:
URL: https://github.com/apache/dolphinscheduler/pull/6063#discussion_r701060873
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/SubProcessTaskExecThread.java
##########
@@ -112,6 +112,31 @@ private void updateParentProcessState(){
this.processInstance.setState(parentProcessInstance.getState());
}
+ /**
+ * wait for the establishment of sub-process-instance
+ * @throws InterruptedException
+ */
+ private void waitSubProcessEstablishment() throws InterruptedException {
+ if (subProcessInstance == null) {
+ while (Stopper.isRunning()) {
Review comment:
In the beginning, I just inserted a condition, by '&&', it caused
SonarCloud smells of cognitive complexity.
this segment is the most complicated in waitTaskQuit() (+3), so i cut it
into a new method.
And the old segment caused another code smell, merge means a big change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
