This is an automated email from the ASF dual-hosted git repository.
kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new a245e14 Inefficient Usages of Java Collections (#6187)
a245e14 is described below
commit a245e141d6e5b383cc9b822cfcb82ae3f57324a5
Author: DittoTool <[email protected]>
AuthorDate: Mon Sep 13 14:36:01 2021 +0800
Inefficient Usages of Java Collections (#6187)
---
.../org/apache/dolphinscheduler/api/aspect/AccessLogAspect.java | 5 +++--
.../main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java | 6 +++---
.../org/apache/dolphinscheduler/spi/params/radio/RadioParam.java | 6 +++---
.../org/apache/dolphinscheduler/spi/params/select/SelectParam.java | 6 +++---
4 files changed, 12 insertions(+), 11 deletions(-)
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/aspect/AccessLogAspect.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/aspect/AccessLogAspect.java
index 03c343b..a34d041 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/aspect/AccessLogAspect.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/aspect/AccessLogAspect.java
@@ -24,6 +24,7 @@ import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
+import java.util.Set;
import java.util.UUID;
import java.util.stream.Collectors;
@@ -99,11 +100,11 @@ public class AccessLogAspect {
if (annotation.ignoreRequestArgs().length > 0) {
String[] parameterNames = ((MethodSignature)
proceedingJoinPoint.getSignature()).getParameterNames();
if (parameterNames.length > 0) {
- List<String> ignoreList =
Arrays.stream(annotation.ignoreRequestArgs()).collect(Collectors.toList());
+ Set<String> ignoreSet =
Arrays.stream(annotation.ignoreRequestArgs()).collect(Collectors.toSet());
HashMap<String, Object> argsMap = new HashMap<>();
for (int i = 0; i < parameterNames.length; i++) {
- if (!ignoreList.contains(parameterNames[i])) {
+ if (!ignoreSet.contains(parameterNames[i])) {
argsMap.put(parameterNames[i], args[i]);
}
}
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
index 453559e..ec3a436 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
@@ -18,8 +18,8 @@ package org.apache.dolphinscheduler.api.dto.gantt;
import com.fasterxml.jackson.annotation.JsonFormat;
-import java.util.ArrayList;
import java.util.Date;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -34,11 +34,11 @@ public class Task {
/**
* task start date
*/
- private List<Long> startDate = new ArrayList<>();
+ private List<Long> startDate = new LinkedList<>();
/**
* task end date
*/
- private List<Long> endDate = new ArrayList<>();
+ private List<Long> endDate = new LinkedList<>();
/**
* task execution date
diff --git
a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParam.java
b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParam.java
index 8d4411a..7ba34d9 100644
---
a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParam.java
+++
b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParam.java
@@ -24,7 +24,7 @@ import
org.apache.dolphinscheduler.spi.params.base.ParamsOptions;
import org.apache.dolphinscheduler.spi.params.base.PluginParams;
import org.apache.dolphinscheduler.spi.params.base.Validate;
-import java.util.ArrayList;
+import java.util.LinkedList;
import java.util.List;
import com.fasterxml.jackson.annotation.JsonProperty;
@@ -65,7 +65,7 @@ public class RadioParam extends PluginParams {
public Builder addParamsOptions(ParamsOptions paramsOptions) {
if (this.options == null) {
- this.options = new ArrayList<>();
+ this.options = new LinkedList<>();
}
this.options.add(paramsOptions);
@@ -104,7 +104,7 @@ public class RadioParam extends PluginParams {
public Builder addValidate(Validate validate) {
if (this.validateList == null) {
- this.validateList = new ArrayList<>();
+ this.validateList = new LinkedList<>();
}
this.validateList.add(validate);
return this;
diff --git
a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParam.java
b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParam.java
index 7ac2758..028874a 100644
---
a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParam.java
+++
b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParam.java
@@ -23,7 +23,7 @@ import
org.apache.dolphinscheduler.spi.params.base.ParamsOptions;
import org.apache.dolphinscheduler.spi.params.base.PluginParams;
import org.apache.dolphinscheduler.spi.params.base.Validate;
-import java.util.ArrayList;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -60,7 +60,7 @@ public class SelectParam extends PluginParams {
public Builder addOptions(ParamsOptions paramsOptions) {
if (this.options == null) {
- this.options = new ArrayList<>();
+ this.options = new LinkedList<>();
}
this.options.add(paramsOptions);
@@ -99,7 +99,7 @@ public class SelectParam extends PluginParams {
public Builder addValidate(Validate validate) {
if (this.validateList == null) {
- this.validateList = new ArrayList<>();
+ this.validateList = new LinkedList<>();
}
this.validateList.add(validate);
return this;
