JinyLeeChina commented on a change in pull request #6185:
URL: https://github.com/apache/dolphinscheduler/pull/6185#discussion_r711560301
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.xml
##########
@@ -22,7 +22,7 @@
<sql id="baseSql">
id, code, name, version, description, project_code,
release_state, user_id,global_params, flag, locations,
- warning_group_id, timeout, tenant_id,operator, operate_time,
create_time,
+ warning_group_id, timeout, tenant_id,operator,execution_type,
operate_time, create_time,
Review comment:
Please add this field to other select statements.
##########
File path:
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
##########
@@ -233,6 +233,14 @@ ProcessInstance
queryLastManualProcess(@Param("processDefinitionCode") Long defi
List<ProcessInstance>
queryByProcessDefineCodeAndStatus(@Param("processDefinitionCode") Long
processDefinitionCode,
@Param("states")
int[] states);
+ List<ProcessInstance>
queryByProcessDefineCodeAndStatusAndNextId(@Param("processDefinitionCode") Long
processDefinitionCode,
+ @Param("states")
int[] states,
+
@Param("id") int id);
Review comment:
please format code
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml
##########
@@ -20,7 +20,7 @@
<mapper
namespace="org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper">
<sql id="baseSql">
id, code, name, version, release_state, project_code, user_id,
description,
- global_params, flag, locations, warning_group_id, create_time,
timeout, tenant_id, update_time
+ global_params, flag, locations, warning_group_id, create_time,
timeout, tenant_id, update_time,execution_type
Review comment:
Please add this field to other select statements
##########
File path:
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessDefinitionLog.java
##########
@@ -39,6 +41,11 @@
@JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss", timezone = "GMT+8")
private Date operateTime;
+ /**
+ * execution type
+ */
+ private ProcessExecutionTypeEnum executionType;
Review comment:
I suggest not to put this field in the processdefinitionlog. The
inheritance method has been obtained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
