lenboo commented on a change in pull request #6346:
URL: https://github.com/apache/dolphinscheduler/pull/6346#discussion_r716030973
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
##########
@@ -59,6 +60,7 @@
"org.apache.dolphinscheduler.server.log.*"
})
})
+@PropertySource(ignoreResourceNotFound = false, value =
"classpath:master.properties")
Review comment:
Unnecessary change
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java
##########
@@ -67,6 +68,7 @@
"org.apache.dolphinscheduler.server.log.*"
})
})
+@PropertySource(ignoreResourceNotFound = false, value =
"classpath:worker.properties")
Review comment:
unnecessary change
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/config/WorkerConfig.java
##########
@@ -26,7 +26,7 @@
import org.springframework.stereotype.Component;
@Component
-@PropertySource(value = "worker.properties")
+@PropertySource(value = "worker.properties")
Review comment:
unnecessary change
##########
File path: dolphinscheduler-server/src/main/resources/logback-master.xml
##########
@@ -76,6 +76,7 @@
<root level="INFO">
<appender-ref ref="TASKLOGFILE"/>
<appender-ref ref="MASTERLOGFILE"/>
+ <appender-ref ref="STDOUT"/>
Review comment:
U C
##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -76,6 +76,7 @@
<root level="INFO">
<appender-ref ref="TASKLOGFILE"/>
<appender-ref ref="WORKERLOGFILE"/>
+ <appender-ref ref="STDOUT"/>
Review comment:
U C
##########
File path: dolphinscheduler-server/src/main/resources/master.properties
##########
@@ -16,7 +16,7 @@
#
# master listen port
-#master.listen.port=5678
+master.listen.port=5678
Review comment:
U C
##########
File path: dolphinscheduler-server/src/main/resources/worker.properties
##########
@@ -31,7 +31,7 @@
#worker.tenant.auto.create=false
# worker max cpuload avg, only higher than the system cpu load average, worker
server can be dispatched tasks. default value -1: the number of cpu cores * 2
-#worker.max.cpuload.avg=-1
+#worker.max.cpuload.avg=100
Review comment:
u C
##########
File path: dolphinscheduler-service/src/main/resources/registry.properties
##########
@@ -24,4 +24,4 @@ registry.servers=127.0.0.1:2181
#maven.local.repository=/usr/local/localRepository
#registry.plugin.binding config the Registry Plugin need be load when
development and run in IDE
-#registry.plugin.binding=./dolphinscheduler-registry-plugin/dolphinscheduler-registry-zookeeper/pom.xml
+registry.plugin.binding=./dolphinscheduler-registry-plugin/dolphinscheduler-registry-zookeeper/pom.xml
Review comment:
U C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
