zhongjiajie commented on a change in pull request #6427:
URL: https://github.com/apache/dolphinscheduler/pull/6427#discussion_r719133320
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/pigeon.vue
##########
@@ -23,7 +23,7 @@
type="input"
size="small"
v-model="targetJobName"
- :placeholder="$t('Please enter TIS DataX job name')">
+ :placeholder="$t('Please enter PIGEON DataX job name')">
Review comment:
Maybe remove the DATAx keyword here too
##########
File path: dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js
##########
@@ -586,7 +586,7 @@ export default {
TargetDataBase: '目标库',
TargetTable: '目标表',
TargetJobName: 'TIS目标任务名',
- 'Please enter TIS DataX job name': '请输入TIS DataX任务名',
+ 'Please enter PIGEON DataX job name': '请输入TIS DataX任务名',
Review comment:
Maybe we should change the describe here, about the keyword `DataX` and
`TIS`, BTW, please change `en_US.js` too
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/canvas/taskbar.scss
##########
@@ -174,8 +174,8 @@
&.icos-switch {
background-image: url("../images/task-icos/switch_hover.png");
}
- &.icos-tis {
- background-image: url("../images/task-icos/tis_hover.png");
+ &.icos-pigeon {
Review comment:
Why we have two `tis` icos here in L159 and L177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
